feat: expose multiple constructors #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulisius
requested changes
Oct 2, 2018
There was a problem hiding this comment.
This is good work @moonray !. Thanks for sending a PR :D. Have added a couple of changes. Apart from these, we'd also have to update the README.
cc @mastilver.
|
|
||
| import DynamicCdnWebpackPlugin, {pluginName} from './dynamic-cdn-webpack-plugin'; | ||
|
|
||
| export default class HtmlDynamicCdnWebpackPlugin extends DynamicCdnWebpackPlugin { |
There was a problem hiding this comment.
Nit: I feel there is no need to export this as default. We are renaming the exports in src/index.js, so might as well do a named export
| } | ||
| }; | ||
|
|
||
| export default class DynamicCdnWebpackPlugin { |
There was a problem hiding this comment.
Same thing about default exports
| }); | ||
| } | ||
| } | ||
| export {default as HtmlDynamicCdnWebpackPlugin} from './html-dynamic-cdn-webpack-plugin'; |
There was a problem hiding this comment.
Once we remove the default export, we can just do something like
export * from './html-dynamic-cdn-webpack-plugin';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50