Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry count massa module cache #4793

Open
wants to merge 6 commits into
base: mainnet_2_3
Choose a base branch
from

Conversation

Leo-Besancon
Copy link
Collaborator

@Leo-Besancon Leo-Besancon commented Dec 17, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Note: as we currently clear the cache in main when the node starts, this does not impact the current code.
It's only fixed to avoid potential future errors if this is changed.

As a result, this does not need to be versioned.

@Leo-Besancon Leo-Besancon force-pushed the fix_entry_count_massa_module_cache branch from 60d9d3a to deef41e Compare December 17, 2024 15:11
@Leo-Besancon
Copy link
Collaborator Author

Updated to simply clear cache in new, and setting the entry_count to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants