Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add server tests #4488

Merged
merged 2 commits into from
Nov 6, 2023
Merged

add server tests #4488

merged 2 commits into from
Nov 6, 2023

Conversation

modship
Copy link
Member

@modship modship commented Oct 17, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@modship modship marked this pull request as ready for review October 18, 2023 13:22
@modship modship requested a review from aoudiamoncef October 18, 2023 13:23
@modship modship linked an issue Oct 19, 2023 that may be closed by this pull request
API unit tests #4426
Closed
70 tasks
@modship modship requested a review from Leo-Besancon October 25, 2023 07:06
@modship
Copy link
Member Author

modship commented Nov 2, 2023

bors merge

bors bot added a commit that referenced this pull request Nov 2, 2023
@bors @modship
Merge #4488
19b7673 
4488: add server tests r=modship a=modship

* [x] document all added functions
* [ ] try in sandbox /simulation/labnet
  * [ ] if part of node-launch, checked using the `resync_check` flag
* [x] unit tests on the added/changed features
  * [x] make tests compile
  * [x] make tests pass 
* [ ] add logs allowing easy debugging in case the changes caused problems
* [ ] if the API has changed, update the API specification

Co-authored-by: modship <[email protected]>
@bors bors
Copy link
Contributor

bors bot commented Nov 2, 2023

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

Response status code: 422
{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@modship
Copy link
Member Author

modship commented Nov 6, 2023

bors merge

@Leo-Besancon Leo-Besancon changed the base branch from main to securnet_wip November 6, 2023 14:56
@modship modship merged commit 0271865 into securnet_wip Nov 6, 2023
11 checks passed
damip pushed a commit that referenced this pull request Nov 8, 2023
@Leo-Besancon @modship
@litchipi @AurelienFT @Eitu33 @bilboquet
Securnet WIP (#4517)
6375704 
* Update securnet

* add server tests (#4488)

* Implement parametric tests for bootstrap (#4454)

* Add tests for bootstrap
* Add new tests bootstrap (#4509)

Signed-off-by: Litchi Pi <[email protected]>
Co-authored-by: AurelienFT <[email protected]>

* remove testing import

* fix clippy

* Update bootstrap limits (again :) ) (#4518)

* Decrease timeouts, decrease message_size

* Update message_max_size and comment for updates

* Fix smart-contracts gas payments (#4505)

* Update packages

* Pay VM creation and compilations correctly

* Use max_instance_cost for default compilation

* Update module costs

* Minor metrics

* Tmp module metrics and high max_instance value for testing

* Calibrated costs for compilation and instance + compilation metrics cleanup

* Change costs and use runtime branch

* Add SC gas doc & improve CL compilation payments

* Update gas costs & other minor changes

* Clippy fixes

* Cargo.toml & cfg fixes

* Remove context payments and update ABI costs

* Update documentation

* Impl get_tmp_module

* Update doc

* Review updates

* Doc

* Loader documentation

* Fmt

* Remove compilation timers

* Add gas to base operation (tx, roll buy & sell)

Signed-off-by: Jean-François <[email protected]>

* Fix majority of tests

* Fix remaining tests

* Update unit test SC src tag

* Move SP compilation payment to OP and ABI costs

* Update gas documentation

* Update RuntimeModule usage, fix from_op, add sp compil to pool config, fix tests

* Update gas table doc

* Fix tests

* Add an important little bit of doc

* saturating_add on sp cost

---------

Signed-off-by: Jean-François <[email protected]>
Co-authored-by: Jean-François <[email protected]>

* Reduce block size to 300k (#4519)

* fix event filter (#4422)

* Update genesis and versions (#4523)

* fix fmt

* fix clippy

* Update securnet (#4525)

* update package version and genesis

* update lock

* Fix send_operation GRPC test

* Update mock.rs

* Change runtime target to latest main rev

* update genesis

---------

Signed-off-by: Litchi Pi <[email protected]>
Signed-off-by: Jean-François <[email protected]>
Co-authored-by: Modship <[email protected]>
Co-authored-by: Litchi Pi (Tim) <[email protected]>
Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: Eitu33 <[email protected]>
Co-authored-by: Jean-François <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@aoudiamoncef aoudiamoncef Awaiting requested review from aoudiamoncef

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API unit tests
2 participants
@modship @Leo-Besancon