Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] ci 추가 #12

Merged
merged 9 commits into from
May 16, 2024
Merged

[feature] ci 추가 #12

merged 9 commits into from
May 16, 2024

Conversation

Ahn-seokjoo
Copy link
Collaborator

@Ahn-seokjoo Ahn-seokjoo commented May 13, 2024 •
edited
Loading

개요

이슈 링크 혹은 PR 내용 요약

CI 추가했읍니다

작업 내용

실제 작업 내용

CI 추가, 린트 체크 CI 추가, 플리퍼 세팅 수정

시연 화면 (option)

실행 스크린샷 혹은 영상 첨부

기능A 구현 기능B 구현 ...
...

To Reviers

리뷰어들에게 전할 말

  1. 플리퍼 debugImplementation하면 빌드시에 unresolved reference로 빌드가 실패하는데, 회사에서 어케 쓰고 있는지 확인해봐야 할듯 ㅠ debugImplementation 라서 release 빌드에서 import를 못찾는 거같아요 ;ㅅ;
  2. 이 pr 머지 이후에는 spotless 안돌리면 린트, 빌드 둘다 실패해요 빌드에서 spoltessCheck가 자동으로 들어가 있던데, 빌드에서는 spoltessCheck 뺴는 방법을 모르겠어서;; 찾아보고 뺼수 있음 빼볼게요 (우리 그레이들 세팅에 spotless가 있어서 그런것 같기도..)
    image. ==> 맞네용 spotless 주석처리하면 Build CI에서도 Spotless 안도넹
    다만,,,,, 빌드CI는 release, master, feature, hotfix 등등에 pr생성하면 도는데, lint_check CI는 �무조건 돌게 해놔서 세팅이 살짝 다르긴 한데, lint_check는 뺴도 될것 같음 말해주세욤 지우게

@Ahn-seokjoo Ahn-seokjoo self-assigned this May 13, 2024
@Ahn-seokjoo Ahn-seokjoo added the feature develop feature label May 13, 2024
Ahn-seokjoo
Ahn-seokjoo commented May 13, 2024
View reviewed changes
.github/workflows/lint_check.yaml
@@ -0,0 +1,31 @@
name: Lint Check
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 build에서도 체크해서 지워도 되긴 하는데, CI 도는 브랜치 세팅이 살짝 다름 (모든 pr에서는 lint_check 함, build는 [ "feature**", "hotfix**", "release**", "develop", "master" ] 일때만

fbghgus123
fbghgus123 reviewed May 14, 2024
View reviewed changes
presenter/src/main/java/com/mashup/dorabangs/presenter/ui/theme/Theme.kt
@@ -18,13 +18,13 @@ import androidx.core.view.WindowCompat
private val DarkColorScheme = darkColorScheme(
primary = Purple80,
secondary = PurpleGrey80,
tertiary = Pink80
tertiary = Pink80,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마지막 파라미터에 콤마를 붙이는구만

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메롱

fbghgus123
fbghgus123 approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@fbghgus123 fbghgus123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿좝입니다 ~~

ddyeon
ddyeon approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@ddyeon ddyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint check 모든 브랜치에서 돈다는거쥬,,? 전 좋습니다~~
멋쟁이 안석주😎

@Ahn-seokjoo Ahn-seokjoo merged commit 2ad4873 into develop May 16, 2024
2 checks passed
@Ahn-seokjoo Ahn-seokjoo deleted the feature/ci branch May 16, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbghgus123 fbghgus123 fbghgus123 approved these changes

@ddyeon ddyeon ddyeon approved these changes

Assignees

@Ahn-seokjoo Ahn-seokjoo

Labels
feature develop feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ahn-seokjoo @ddyeon @fbghgus123