NOMINMAX can be defined already on Windows #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows build doesn't seem to like this with Visual Studio... |
|
I'm happy to consider this change, but it needs to be modified so it passes tests. |
|
Sorry, I did not mean to add the ci.yml changes here, only 1 commit. Should be better now. |
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the changes discussed here.
I am building on Windows with MSVC, MSYS2 gcc and clang. I will submit a pull request for https://github.com/mas-bandwidth/netcode too. For the github actions, I will open an issue instead, there are a couple of issues with it.