-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MP-2425 Burn fee collector denom rewards #428
Open
dancreee
wants to merge
7
commits into
master
Choose a base branch
from
mp-2425_burn_fee_collector_rewards
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancreee
changed the title
Remove sending of rewards, burn rewards for fee collector denom instead
MP-2425 Burn fee collector denom rewards
Aug 3, 2024
dancreee
commented
Aug 3, 2024
piobab
reviewed
Aug 14, 2024
piobab
reviewed
Aug 14, 2024
piobab
reviewed
Sep 11, 2024
@@ -1 +1 @@ | |||
pub mod v2_0_0; | |||
pub mod v2_0_2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now on ntrn we have 2.1.0. We should update migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the code that would distribute via ibc transfer the fee_collector_denom, and replaced it with a burn msg.
This removes the ability for us to do buy & distribute, but this will be a different implementation for DAODAO anyway (currently not supported for tokenFactory tokens AFAIK) so makes sense to remove it and later re-implement it.
We still do the ibc transfer of the safety fund denom to Mars Hubs Safety Fund module on both Osmosis and Neutron outposts. Once we change the Safety Fund to flow to the DAODAO treasury we can probably pull out the Neutron specific impl. of ibc_transfer.
After completing this work i'm not so sure it's actually worth rolling out until we implement more of the upcoming work to the rewards collector.
This is because:
So we could end up with the following protocol revenue buckets that can be configured by governance:
These 3 should add up to 100%. Additionally within Revenue Share we could have n number of shares with a rate (that add up to 100% of the Revenue Share Rate).
In the future we can also add Buy & LP bucket and Buy & Distribute bucket. Because so many I think the code design needs to be re-worked a bit
TODO