Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react-admin v5 #4

Merged
merged 12 commits into from
Jun 21, 2024
Merged

Upgrade to react-admin v5 #4

merged 12 commits into from
Jun 21, 2024

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jun 20, 2024

Tests won't pass until we provide a token in the repository actions settings

@djhi djhi added the RFR label Jun 20, 2024
@djhi djhi removed the RFR label Jun 20, 2024
pull_request:

jobs:
typecheck:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make only one job with both typecheck and test, as most of the job time is spent initializing

@fzaninotto
Copy link
Member

I have a few UI issues.

  • The dark theme isn't legible in some pages:

image

  • we need to add the theme switcher back to the appbar, and default to light theme
  • The user menu isn't vertically centered in the appbar
    image
  • the tanstack query devtools icon is too large

@fzaninotto
Copy link
Member

2 things are still missing:

  • default to light theme
  • the tanstack query devtools icon is too large

@djhi
Copy link
Contributor Author

djhi commented Jun 21, 2024

default to light theme

Why not let the user system decide?

@fzaninotto
Copy link
Member

Why not let the user system decide?

Because the dark theme of this app isn't very nice IMHO

@fzaninotto fzaninotto merged commit 4836201 into main Jun 21, 2024
1 check passed
@fzaninotto fzaninotto deleted the upgrade-react-admin-5 branch June 21, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants