Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onSubmitSuccess default notification fixed #1362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomy2105
Copy link

@tomy2105 tomy2105 commented Sep 5, 2017

This fixes #1258.

If onSubmitSuccess returns false default notification no longer shown.

If onSubmitSuccess retruns false default notification no longer shown.
@tomy2105
Copy link
Author

tomy2105 commented Sep 6, 2017

I don't understand check failed error message "No selenium server jar found at", can someone please see what happened and why please.

@jamespsterling
Copy link

any plan to merge this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onSubmitSuccess Chain show success notification even when default action is cancel
2 participants