Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add emoji support, with some tests #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

brad
Copy link

@brad brad commented May 23, 2014

Hi Mariano,
This is my attempt to add emoji support (#81). Works great for me. It uses my customized version of https://gist.github.com/lepture/2011858
I customized it because the original was missing quite a few emoji. My version pulls a list from Github's API, falling back to a hardcoded version of that list if there is an error, such as Github rate limit being hit (60 requests /hr). With normal usage, the rate limit shouldn't get hit, because snakefire caches it (only hitting the API once every time the program is loaded)
I added some tests of emoji.py for good measure. Let me know what you think!

@raelgc
Copy link
Contributor

raelgc commented May 23, 2014

Simple suggestion: include emoji images as resources.

@brad
Copy link
Author

brad commented May 23, 2014

Totally not a dumb question. The reason I did that is because that dict is a straight copy/paste of the output here. The intention is that if those links are updated, it will be easy to paste in the new dict straight from the API output. I suppose one could write a script to download and add all the images to the repo as resources, but it seems like a lot of effort to me for a sub par result. Getting them from the API will always get you up to date emojis. The user is guaranteed to be online anyway and these tiny files use a negligible amount of bandwidth.

@raelgc
Copy link
Contributor

raelgc commented May 24, 2014

@brad Thank you for the explanations! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants