-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oneDNN #937
Add oneDNN #937
Conversation
I merged this with the recent master (https://github.com/marian-nmt/marian-dev/tree/graemenail-onednn) and tested with the regression tests that we have. Intgemm tests and one wngt19 8bit test fail, but I guess this is expected and in fact can be also because of #933. In our tests, except tests with quantized 8bit models tested on CPU, it also throws the abort here. Other tests pass. As for other comments, as discussed earlier, instead of replacing MKL with oneDNN, we would like to have this backward compatible at least for some time and to keep the previous behavior as default. So oneDNN would be enabled via CMake flag and MKL is used by default if detected. |
Thanks for the comments @snukky. On the LSH abort, it's a while since I looked at this, I don't believe oneDNN provides all the BLAS functions required. From a quick check, I'd guess this #706 (comment) is still the status of non-GEMM BLAS in oneDNN. I had started on the oneDNN + MKL implementation, I'll dig it out. |
Closing in favour of #967 |
TODO
Description
Replaces MKL with oneDNN. This PR should enable completely open-source releases of Marian.
This PR also includes a caching of boost, and a cleaning of the debug build directory. These can be broken off into a separate PR if necessary. During testing, windows builds would fail from running out of space building both debug and release. Since disabling oneDNN JIT profiling the build sizes are smaller.
Related: marian-nmt/marian-regression-tests#86
Closes: #706
List of changes:
cblas_sgemm_batch
inprod.cpp
)mkl_somatcopy
intensor_operators.cpp
)mkl_somatcopy
inpacked_gemm.cpp
)The following have some MKL component, and have not been touched:
src/microsoft
codevs/*
Added dependencies: Intel oneDNN (removing Intel MKL)
How to test
Ran the 1 million sentence testset of WNGT21 through the MKL and oneDNN versions.
Using the
wngt19
model from regression tests.Setup
Ran
#cpu
tagged regression tests. Non-intgemm tests pass.Regression test results
The static binaries are now larger (merge #938 first for comparison).
Checklist