feat: change the sampler's signature for better decisions #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we provided only the parent ID to the sampler, which had returned the sampling state for the new span before creation. But that did not allow any sampling decision to be made with respect to current/new span ID.
I then 360'd, and made it so one could not make sampling decisions based off its parent, and mixed with a bug in tctx (fixed in maraisr/tctx@8ec6b3e) it was impossible to sample an entire trace, than individual spans, without hacks. Whoops!
This PR introduces a change our samplers signature, and provides it with more context to make more educated decisions.
closes: #5