Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web component elements and slot attribute #235

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

knpwrs
Copy link
Contributor

@knpwrs knpwrs commented Oct 25, 2024

The slot attribute is a standard attribute for use with web components: https://developer.mozilla.org/en-US/docs/Web/API/Web_components/Using_templates_and_slots

@markuswustenberg
Copy link
Member

Thanks! I don’t think we have the template and slot elements either?

@knpwrs
Copy link
Contributor Author

knpwrs commented Oct 25, 2024

I was thinking about that and couldn't think of a situation where I (in my workflow) would server-render <template> or <slot>. I can add them though, others may have a use-case.

@knpwrs knpwrs changed the title Add Slot attribute Add web component elements and slot attribute Oct 25, 2024
@knpwrs
Copy link
Contributor Author

knpwrs commented Oct 25, 2024

Updated

@markuswustenberg
Copy link
Member

D’oh, we run into a naming collision of course. Could you suffix each of Slot with El and Attr? And not add the non-suffixed version for now.

@knpwrs
Copy link
Contributor Author

knpwrs commented Oct 25, 2024

Should be all set now.

@markuswustenberg
Copy link
Member

Thanks! Now just add them to the test tables and we’re set. 😊

@knpwrs
Copy link
Contributor Author

knpwrs commented Oct 25, 2024

Tests should be all set now

@markuswustenberg
Copy link
Member

🥳

@markuswustenberg markuswustenberg merged commit 2e44d49 into maragudk:main Oct 25, 2024
7 checks passed
@knpwrs knpwrs deleted the patch-1 branch October 25, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants