Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added GeometryCollection to GeoJSONUtils #556

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from
Open

fix: added GeometryCollection to GeoJSONUtils #556

wants to merge 2 commits into from
+49 −24

Conversation

KiwiKilian
Copy link
Collaborator

@KiwiKilian KiwiKilian commented Dec 15, 2024 •
edited
Loading

  • Added fromGeometryCollection, as GeometryCollection is a valid geometry too
  • Improved some null checks

Noticed these during reviewing #555

@KiwiKilian KiwiKilian requested a review from tyrauber December 15, 2024 10:07
@KiwiKilian
Copy link
Collaborator Author

@jimmyasyraf could you have a look at these changes too?

jimmyasyraf
jimmyasyraf approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@jimmyasyraf jimmyasyraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyasyraf jimmyasyraf jimmyasyraf approved these changes

@tyrauber tyrauber Awaiting requested review from tyrauber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KiwiKilian @jimmyasyraf