Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globe projection render errors after v5.0.0-pre7 with pmtiles #5242

Open
resiliencetheatre opened this issue Dec 19, 2024 · 8 comments
Open
Labels
globe Globe related issues need more info Further information is requested

Comments

@resiliencetheatre
Copy link

maplibre-gl-js version:

  • All pre-releases after 5.0.0-pre.7

browser: Firefox 128.5.0esr (debian 12)

Steps to Trigger Behavior

  1. Replace maplibre-gl-js 5.0.0-pre.7 with more recent pre version (tested up to pre.10)
  2. Open map using pmtiles with globe projection and it renders bad

Link to Demonstration

v5.0.0-pre.10

Image

Expected Behavior

v5.0.0-pre.7

Image

@HarelM
Copy link
Collaborator

HarelM commented Dec 19, 2024

Please provide a proper way to reproduce this issue, screenshots are not enough.
Can you also please see if you can find the offending PR that broke this?

@HarelM HarelM added need more info Further information is requested globe Globe related issues labels Dec 19, 2024
@resiliencetheatre
Copy link
Author

Way to reproduce:

  1. Get example:
    https://github.com/protomaps/PMTiles/blob/main/js/examples/maplibre.html

  2. Change line 39 to:
    url: "pmtiles://https://data.source.coop/protomaps/openstreetmap/v4.pmtiles",

  3. Extract pre7 and pre10 as dist7 and dist10 directories under web server

  4. Modify lines 5 and 6 to load either pre.7 or pre.10 versions of maplibre-gl-js

Observe that pre.10 leaves tiles unloaded, while pre.7 loads them perfectly.

@HarelM
Copy link
Collaborator

HarelM commented Dec 20, 2024

Can you create a JSBin or something similar? It's hard to understand the steps to reproduce this way.
I would also be surprised if this is only relevant to PMTiles so I would encourage you to try and create a reproduction that doesn't require PMTiles.
CC: @kubapelc

@resiliencetheatre
Copy link
Author

Thanks. I'll try better. That 120 GB pmtiles (world) is tough act to deliver as part of demo - but I'll see if I can make it happen. My instance is 100% localhost running on RPi4 and taking it out from there is bit painful and my frontend skills with tooling are bad. But let me see.

@zerda-ocm
Copy link

That 120 GB pmtiles (world) is tough act to deliver as part of demo

From your screenshots it appears that only "ocean" features are disappearing and also at low zoom levels. Maybe the problem is reproducible with a much smaller dataset.

@resiliencetheatre
Copy link
Author

I was able to get this example to show similar thing (even without globe), so it might be fastest way to test it.

@HarelM
Copy link
Collaborator

HarelM commented Dec 22, 2024

Can you please provide a jsbin with the issue? I'm having a hard time understanding how to reproduce this, and what is the minimal reprodction, and if it's related to globe or not, if it's related to pmtiles or not.
There's too many noise and too much comments.
A jsbin with a minimal reproduction can go a long way here...

@CommanderStorm
Copy link

CommanderStorm commented Dec 22, 2024

I think this is a pretty minimal reproduction.

I can reproduce this without the globe mode on large zoom levels => this is only realted to pmtiles or due to some projection changes affecting pmtiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
globe Globe related issues need more info Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants