Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pmtiles map not properly displayed on the lastest codebase version #2

Open
dscp46 opened this issue Dec 15, 2024 · 6 comments
Open

Comments

@dscp46
Copy link

dscp46 commented Dec 15, 2024

Hi,

On the last main branch version, the map data is not properly displayed (countries borders and forest areas are not displayed, some unknown geographical features are mistakenly displayed as lakes with zoom level above or equal to 10):
Capture d’écran du 2024-12-15 16-05-03

We've cross-tested and reproduced this on Mozilla Firefox and Google Chrome.

For reference, the chosen pmtiles file is https://build.protomaps.com/20241209.pmtiles (Protomaps version 4 format). Is a format incompatibility to incriminate?

Also, the web debug console seems to refer to 4 pmtiles files for satellite data. Could you confirm where I can fetch those files?
Capture d’écran du 2024-12-15 16-04-04

Kind regards,

@dscp46
Copy link
Author

dscp46 commented Dec 15, 2024

Hi again,

Update: your libremap-js version is incompatible with the protomaps version 4 file format. The map properly renders when using the last public known Protomaps 3.x file ( 20240812.pmtiles ).
Capture d’écran du 2024-12-15 16-49-43

Kind regards.

@resiliencetheatre
Copy link
Owner

See this:

gateway:/opt/edgemap/edgeui/styles# ls -l
total 936
-rw-r--r--    1 root     root           176 Nov 28 01:46 README.txt
-rw-r--r--    1 root     root         88246 Nov 28 11:11 style-v3.json
-rw-r--r--    1 root     root        414375 Dec  1 01:23 style-v4-dark.json
-rw-r--r--    1 root     root        414155 Nov 28 11:11 style-v4.json
lrwxrwxrwx    1 root     root            18 Nov 28 11:11 style.json -> style-v4-dark.json
-rw-r--r--    1 root     root         25140 Nov 28 01:46 style.json.tilemaker

There is indeed style changes between protomaps V3 and V4. I think we should have V4 symlinked by default? See also map.php line 402.

@resiliencetheatre
Copy link
Owner

And yes - latest master (or 5.0.0-pre9) from maplibre-gl-js does not render globe projection right. v5.0.0-pre8 works still just fine. I am using pre8 and waiting for final v5.0.0 release to see where it takes us.

@resiliencetheatre
Copy link
Owner

Regarding satellite images, you can create them by yourself and I've done just those four examples from bing to pmtiles. I need to update my wiki how you can create those. For now you can ignore them or even comment them out from style. I'll comment here when I update my documentation about satellite pmtiles creation.

@resiliencetheatre
Copy link
Owner

And would be good to create issue to maplibre-gl-js about that pmtiles incompatibility?

@resiliencetheatre
Copy link
Owner

Issue created:

maplibre/maplibre-gl-js#5242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants