Handle failed matching if at least one image has no GPS data #217
Conversation
|
What should we do if one image does not has GPS and match selection using GPS distance is enabled? The current behavior is to deactivate the GPS based match selection altogether. If I understand correctly, with this patch we would keep it on with Does this make sense? What behavior would you want, @bdholt1 ? |
|
To weigh in on this discussion as I have also had the same problem: I consider the correct algorithmic behavior would be to include images that have invalid or missing GPS information in all matching pairs, hence, to match such an image with ALL the other images. If you have, as I do, usually a large amount of images with valid GPS information and just a few where this is missing, it would be a huge speedup compared to having all pairs evaluated. Just had a quick glance into the code: I think it would be a rather minor patch to implement, I hope I'll have time next week to try it. |
|
Hi @bdholt1! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Fix for #198
The fix worked for me, don't see why everyone else using this library should need to apply the patch too.