Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing export type of MapBoxZoomEvent #13368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fxnm
Copy link

@fxnm fxnm commented Dec 22, 2024

Added missing type definition for MapBoxZoomEvent. The type definition got accidentally removed in f338be4 and in the "revert" the type type definition was not added back 1fea1bb.

https://docs.mapbox.com/mapbox-gl-js/api/events/#mapboxzoomevent

Launch Checklist

  • Make sure the PR title is descriptive and preferably reflects the change from the user's perspective.
  • Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
  • Manually test the debug page.
  • Write tests for all new functionality and make sure the CI checks pass.
  • Document any changes to public APIs.
  • Post benchmark scores if the change could affect performance.
  • Tag @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes.
  • Tag @mapbox/gl-native if this PR includes shader changes or needs a native port.

@fxnm fxnm requested a review from a team as a code owner December 22, 2024 13:23
@CLAassistant
Copy link

CLAassistant commented Dec 22, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants