Stop marker from flashing on initial load if it's occluded by the globe #13344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #13000. See this video for a demonstration of the bug:
bug.mp4
Here is the same example, after the fix:
fixed.mp4
Here is a possibly relevant conversation from when the throttling was initially added in 2021: #10564 (comment). I didn't notice any performance issues when testing the fix, but maybe someone more experienced can tell if this fix causes problems somewhere.
I tested also with adding an
isInitialLoad
boolean toMarker
's_update
function so that we could keep the_fadeTimer
. It caused problems with popups flashing on initial load, but I managed to fix them. That solution was less clean than this one in my opinion, but I think it's still a possibility if we want to keep the fade timer.This is my first PR to Mapbox, please tell me if there is something that I did incorrectly or that I should still fix, I'm open to all feedback! :)
Launch Checklist
@mapbox/map-design-team
@mapbox/static-apis
if this PR includes style spec API or visual changes.@mapbox/gl-native
if this PR includes shader changes or needs a native port.