Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add altitude attribute to Marker and Popup #13335

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

yangtanyu
Copy link

Hi,
I have added a new property to Marker and Popup that represents the height above the ground. This is very useful for rendering 3D models and marking objects with specific heights. I hope to contribute to the open-source community.

Please read the instructions and review the code, thanks!

Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
before:
image
image

after:
image
image

Manually test the debug page.
I used npm run start debug and added a markers-altitude.html debugging page

Write tests for all new functionality and make sure the CI checks pass.
I used npm run test and it passed the test

Document any changes to public APIs.
/src/ui/marker.ts -> line:58
/src/ui/popup.ts -> line:80

this PR includes style spec API or visual changes.
@mapbox/static-apis @mapbox/map-design-team

Launch Checklist

  • Make sure the PR title is descriptive and preferably reflects the change from the user's perspective.
  • Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
  • Manually test the debug page.
  • Write tests for all new functionality and make sure the CI checks pass.
  • Document any changes to public APIs.
  • Post benchmark scores if the change could affect performance.
  • Tag @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes.
  • Tag @mapbox/gl-native if this PR includes shader changes or needs a native port.

@yangtanyu yangtanyu requested a review from a team as a code owner November 25, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant