-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add altitude attribute to Marker and Popup #13335
Open
yangtanyu
wants to merge
16
commits into
mapbox:main
Choose a base branch
from
yangtanyu:marker-altitube
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added a new property to Marker and Popup that represents the height above the ground. This is very useful for rendering 3D models and marking objects with specific heights. I hope to contribute to the open-source community.
Please read the instructions and review the code, thanks!
Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
before:
after:
Manually test the debug page.
I used npm run start debug and added a markers-altitude.html debugging page
Write tests for all new functionality and make sure the CI checks pass.
I used npm run test and it passed the test
Document any changes to public APIs.
/src/ui/marker.ts -> line:58
/src/ui/popup.ts -> line:80
this PR includes style spec API or visual changes.
@mapbox/static-apis @mapbox/map-design-team
Launch Checklist
@mapbox/map-design-team
@mapbox/static-apis
if this PR includes style spec API or visual changes.@mapbox/gl-native
if this PR includes shader changes or needs a native port.