Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various neogeo related driver cleanups: #13119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Various neogeo related driver cleanups: #13119

wants to merge 2 commits into from
+550 −479

Conversation

cam900
Copy link
Contributor

@cam900 cam900 commented Dec 25, 2024 •
edited
Loading

  • neogeo/midas.cpp:
    • Split hammer to derivated class
    • Reduce runtime tag lookups
    • Fix namings
  • neogeo/neogeo_spr.cpp:
    • Fix typename consistency
    • Use enum for fix layer bankswitch type
    • Make some variables constant
    • Reduce preprocessor macros
    • Move various functions and variables into protected: section
    • Fix filename comment
    • Fix naming
  • neogeo/neogeo.cpp:
    • Suppress side effects for debugger reads
    • Reduce literal tag usages
    • Make some variables constant
  • neogeo/neogeocd.cpp:
    • Fix code style consistency, Use lowercase hexadecimal digits and variable names
    • Move various variables and functions into private: section
    • Reduce preprocessor macros
    • Suppress side effects for debugger reads
    • Make some variables constant
    • Fix save states
  • neogeo/neopcb.cpp:
    • Reduce literal tag usage
    • Fix metadata related to hardware configuration

@cam900
Various neogeo related driver cleanups:
5f2382a 
- neogeo/midas.cpp:
 - Split hammer to derivated class
 - Reduce runtime tag lookups
 - Fix namings
- neogeo/neogeo_spr.cpp:
 - Fix typename consistency
 - Use enum for fix layer bankswitch type
 - Make some variables constant
 - Reduce preprocessor macros
 - Move various functions and variables into protected: section
 - Fix filename comment
 - Fix naming
- neogeo/neogeo.cpp:
 - Suppress side effects for debugger reads
 - Reduce literal tag usages
 - Make some variables constant
- neogeo/neogeocd.cpp:
 - Fix code style consistency, Use lowercase hexadecimal digits and variable names
 - Move various variables and functions into private: section
 - Reduce preprocessor macros
 - Suppress side effects for debugger reads
 - Make some variables constant
 - Fix save states
- neogeo/neopcb.cpp:
 - Reduce literal tag usage
 - Fix metadata related to hardware configuration
@cam900
neogeo/neogeocd.cpp: Reorder variables and functions in class header
2b651ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cam900