-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wring out starline parsing #132
Open
CyberiaResurrection
wants to merge
37
commits into
makhidkarun:master
Choose a base branch
from
CyberiaResurrection:WringOutParsing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wring out starline parsing #132
CyberiaResurrection
wants to merge
37
commits into
makhidkarun:master
from
CyberiaResurrection:WringOutParsing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberiaResurrection
force-pushed
the
WringOutParsing
branch
from
December 27, 2024 02:52
bef82f9
to
3a0ea23
Compare
CyberiaResurrection
force-pushed
the
WringOutParsing
branch
from
December 27, 2024 03:31
3a0ea23
to
3610b2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tighten up starline parsing according to the following property:
Given a string conforming to the
ParseStarInput.starline
regex, it either:parse_line_into_star
, or;parse_line_into_star
into aStar
object.Given 2, above, it should then be output to a string representation, cleanly re-parsed by
parse_line_into_star,
and then output to the same string representation.IOW, re-parsing a
Star
object should be idempotent in the string representation.Given that hypothesis is already hooked up and running clean, the next step was to hook up hypofuzz - a hypothesis-powered fuzzer.
I hooked up hypofuzz in another branch and probably won't be pushing the hookup up for review, as it brings in a whole lot of packages to view the fuzzing results that aren't relevant to PyRoute.
I then started a cycle of "run hypofuzz until property is violated - fix violation - repeat" until it ran cleanly overnight (approx 11 h 45 min, and ~103k inputs, all without triggering a new path, let alone finding a property violation).
Yes, it is very unlikely that the strings added as examples will even turn up in production - but now, those strings (and strings like them) are far less likely to cause any sort of parsing issue.