-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify and extend star canonicalisation #117
Merged
CyberiaResurrection
merged 15 commits into
makhidkarun:master
from
CyberiaResurrection:VerifyStarCanonicalisation
Jun 30, 2024
Merged
Verify and extend star canonicalisation #117
CyberiaResurrection
merged 15 commits into
makhidkarun:master
from
CyberiaResurrection:VerifyStarCanonicalisation
Jun 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberiaResurrection
force-pushed
the
VerifyStarCanonicalisation
branch
from
June 25, 2024 10:52
cd89cad
to
4912d20
Compare
CyberiaResurrection
force-pushed
the
VerifyStarCanonicalisation
branch
from
June 25, 2024 11:01
4912d20
to
502d976
Compare
CyberiaResurrection
force-pushed
the
VerifyStarCanonicalisation
branch
from
June 26, 2024 14:31
406e0fd
to
4fbde9f
Compare
CyberiaResurrection
force-pushed
the
VerifyStarCanonicalisation
branch
from
June 26, 2024 23:01
4fbde9f
to
3def9e9
Compare
tjoneslo
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the basic star canonicalisation guts is in, extend them to (mostly) handle the T5 trade classes. The major exception is Barren/Dieback trade codes - I decided to send up what I had to stop the perfect being the enemy of the good.
In T5, both Barren and Dieback require Pop 0, Gov 0 and Law 0 - Dieback also requires Atmo 2+. As currently, Pyroute treats Barren as requiring only Pop 0, I've left that as-is for the moment.
This required:
Extending the default size option in _{check,fix}_planet_code to handle size E and F planets.
Likewise extending the default size option in _{check,fix}_trade_code to handle size E and F planets.
Extend Hi pop checks to handle population codes of E and F.
Extend _{check,fix}_planet_code calls for the "Oc" trade code to handle size E and F planets.