Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify and extend star canonicalisation #117

Conversation

CyberiaResurrection
Copy link
Contributor

@CyberiaResurrection CyberiaResurrection commented Jun 25, 2024

Now the basic star canonicalisation guts is in, extend them to (mostly) handle the T5 trade classes. The major exception is Barren/Dieback trade codes - I decided to send up what I had to stop the perfect being the enemy of the good.

In T5, both Barren and Dieback require Pop 0, Gov 0 and Law 0 - Dieback also requires Atmo 2+. As currently, Pyroute treats Barren as requiring only Pop 0, I've left that as-is for the moment.

This required:
Extending the default size option in _{check,fix}_planet_code to handle size E and F planets.
Likewise extending the default size option in _{check,fix}_trade_code to handle size E and F planets.
Extend Hi pop checks to handle population codes of E and F.
Extend _{check,fix}_planet_code calls for the "Oc" trade code to handle size E and F planets.

@CyberiaResurrection CyberiaResurrection force-pushed the VerifyStarCanonicalisation branch from cd89cad to 4912d20 Compare June 25, 2024 10:52
@CyberiaResurrection CyberiaResurrection force-pushed the VerifyStarCanonicalisation branch from 4912d20 to 502d976 Compare June 25, 2024 11:01
@CyberiaResurrection CyberiaResurrection force-pushed the VerifyStarCanonicalisation branch from 406e0fd to 4fbde9f Compare June 26, 2024 14:31
@CyberiaResurrection CyberiaResurrection force-pushed the VerifyStarCanonicalisation branch from 4fbde9f to 3def9e9 Compare June 26, 2024 23:01
@CyberiaResurrection CyberiaResurrection merged commit 8c42a3d into makhidkarun:master Jun 30, 2024
1 check passed
@CyberiaResurrection CyberiaResurrection deleted the VerifyStarCanonicalisation branch June 30, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants