Komelin Gleb Croc Java School #5

GlebKom · 2023-10-31T13:38:13Z

No description provided.

src/main/java/croc/education/ws2023spb/knightsmove/ChessPositionParser.java

src/main/java/croc/education/ws2023spb/knightsmove/KnightsMoveCheckerFactory.java

…nly throws IllegalMoveException. 2) Edited algorithm to check is move can be made, now it uses less resources and performs faster.

…er using static method of class Character getNumericValue

mak-42

Мне нравится ваша попытка использовать стандартные функции в решении задачи. Но в некоторых случаях вы не учитываете их особенности. Осталось решить единственную проблему.

src/main/java/croc/education/ws2023spb/knightsmove/ChessPositionParser.java

…d with RegEx.

mak-42 · 2023-11-12T21:06:28Z

Спасибо за хорошую работу.

GlebKom added 4 commits October 31, 2023 16:27

Komelin Gleb fork

87ca517

Komelin Gleb fork

74da9bb

Komelin Gleb fork

5c38605

Edited mistake in ChessPositionImpl constructor

8696631

mak-42 requested changes Oct 31, 2023

View reviewed changes

GlebKom added 2 commits November 1, 2023 10:39

Edited check method. 1) Now it doesn't write message in console and o…

899ae87

…nly throws IllegalMoveException. 2) Edited algorithm to check is move can be made, now it uses less resources and performs faster.

Edited check for second argument in position. Added check isDigit aft…

ff2fa38

…er using static method of class Character getNumericValue

GlebKom requested a review from mak-42 November 1, 2023 19:46

mak-42 requested changes Nov 4, 2023

View reviewed changes

src/main/java/croc/education/ws2023spb/knightsmove/ChessPositionParser.java Outdated Show resolved Hide resolved

GlebKom added 3 commits November 4, 2023 16:46

Changed position check. Now second letter in position is being checke…

df165bb

…d with RegEx.

Edited some mistakes in ChessPositionParser

dcf7338

Edited some mistakes in ChessPositionParser

98cf058

GlebKom requested a review from mak-42 November 5, 2023 13:49

Edited some mistakes in ChessPositionParser

322fce3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Komelin Gleb Croc Java School #5

Komelin Gleb Croc Java School #5

GlebKom commented Oct 31, 2023

mak-42 left a comment

mak-42 commented Nov 12, 2023

Komelin Gleb Croc Java School #5

Are you sure you want to change the base?

Komelin Gleb Croc Java School #5

Conversation

GlebKom commented Oct 31, 2023

mak-42 left a comment

Choose a reason for hiding this comment

mak-42 commented Nov 12, 2023