Task8 by Lesiv K #11
Open
Task8 by Lesiv K #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mak-42
commented
Nov 4, 2023
| */ | ||
| @Test | ||
| public void parseSomethingInside() { | ||
| public void parseSomethingInside() throws IllegalPositionException { |
There was a problem hiding this comment.
При выдаче задания предупреждали, что текст тестов должен оставаться неизменным. Если вам понадобилось его изменить, возможно, вы что-то реализовали неправильно.
| public void check(String[] positions) throws IllegalMoveException { | ||
| ChessPosition pos; | ||
| try { | ||
| pos = ChessPositionParser.parse(positions[0]); |
There was a problem hiding this comment.
Мне нравится ваш подход, но надо немного его доработать. Здесь получим непонятное для пользователя исключение, если он по ошибке не указал ни одной клетки в качестве аргумента запуска программы.
| } | ||
| pos = nextPos; | ||
| } | ||
| System.out.print("OK"); |
There was a problem hiding this comment.
Здесь нарушается принцип единственной ответственности: тут и производится проверка, и выводится сообщения пользователю.
Следует оставить только проверку, а сообщение выводить в другом месте.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.