Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent config editor dialog overflow when there are too many file structure sections #2097

Closed
wants to merge 22 commits into from

Conversation

NV4RE
Copy link

@NV4RE NV4RE commented Dec 25, 2024

Description

This PR fixes the editor dialog overflow issue that occurs when the configuration file contains numerous sections. Previously, when a config file had many sections, the file structure sidebar would extend beyond the viewport height, causing the entire dialog to overflow. The fix adds proper height constraints and scrolling behavior to maintain a clean layout.

Related Tickets & Documents

No existing issue - implemented direct fix due to straightforward solution.

Note: Future enhancement could involve refactoring the layout to use CSS Grid for improved structure:

grid-template-areas:
  "header header"
  "editor structure"

Mobile & Desktop Screenshots/Recordings

Before:

  • File structure sidebar extended beyond viewport height
  • Caused entire dialog to overflow
  • Required vertical scrolling of whole interface
before.mov

After:

  • Content properly contained within viewport
  • File structure sidebar scrolls independently
  • Clean, consistent layout maintained
after.mov

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 25, 2024
@meteyou
Copy link
Member

meteyou commented Dec 26, 2024

Hey @NV4RE! Thanks for your PR, but I think it is already fixed. Can you please explain the difference between your PR an this PR #2079?

@NV4RE
Copy link
Author

NV4RE commented Dec 26, 2024

Hey @NV4RE! Thanks for your PR, but I think it is already fixed. Can you please explain the difference between your PR an this PR #2079?

Oh, you're right. I'll close this PR since it addresses the same issue. Thank you for bringing this to my attention!

@NV4RE NV4RE closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants