fix(macro-prompts): preserve outer quotes #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
@pedrolamas If you can give this a review when you are available, that would be appreciated! |
Previously if you had a macro prompt such as the following, the modal title would display `Question`, not `"Question"`. However, in other projects (Klipperscreen and Fluidd), they will preserve those outer quotes and they will be included in the title. This change makes Mainsail consistent with the other implementations. ``` RESPOND TYPE=command MSG="action:prompt_begin \"Question\"" RESPOND TYPE=command MSG="action:prompt_button Button1|RESPOND MSG=\"Clicked it!\"" RESPOND TYPE=command MSG="action:prompt_show" ```
ammmze
force-pushed
the
macro-prompts-preserve-quotes
branch
from
7ece9a4 to
14585cc
Compare
meteyou
changed the title
meteyou
approved these changes
Dec 10, 2024
|
@ammmze thx for your PR! I just changed the title to "fix", because i think its more a fix than a feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously if you had a macro prompt such as the following, the modal title would display
Question, not"Question". However, in other projects (Klipperscreen and Fluidd), they will preserve those outer quotes and they will be included in the title. This change makes Mainsail consistent with the other implementations.Related Tickets & Documents
Implements discussion from #2045.
Mobile & Desktop Screenshots/Recordings
[optional] Are there any post-deployment tasks we need to perform?