Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add heartbeat to the moonraker websocket #2003

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Sep 9, 2024

Description

This PR adds a heartbeat function to the Websocket and disconnect, when no ping arrive from Moonraker for more than 10 seconds.

Related Tickets & Documents

fixes #1536

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

@meteyou meteyou requested review from dw-0 and rackrick September 9, 2024 20:42
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 11, 2024
@meteyou meteyou merged commit f4bbe45 into mainsail-crew:develop Sep 11, 2024
11 checks passed
@meteyou meteyou deleted the feat/websocket-heartbeat branch September 11, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inform when mainsail can't fetch new data from printer
2 participants