Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor machine settings panel #1991

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Sep 4, 2024

Description

This PR refactor the MachineSettingsPanel to remove outdated split and add some extra padding on the top from the panel to align the input field with label in the panel.

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

image

[optional] Are there any post-deployment tasks we need to perform?

none

@meteyou meteyou requested review from dw-0 and rackrick September 4, 2024 18:45
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 4, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 7, 2024
@meteyou meteyou merged commit 6fd64df into mainsail-crew:develop Sep 7, 2024
14 checks passed
@meteyou meteyou deleted the refactor/machine-settings-panel branch September 7, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants