Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix splitter detection bug #178 #180

Closed
wants to merge 3 commits into from
Closed

Fix splitter detection bug #178 #180

wants to merge 3 commits into from

Conversation

raphael0202
Copy link

See #178

@mailgun-ci
Copy link

Can one of the admins verify this patch?

@obukhov-sergey
Copy link
Member

@mailgun-ci test this please

@obukhov-sergey
Copy link
Member

Thx for the PR @raphael0202 can you plz fix the test:

...........................................................F.............................
======================================================================
FAIL: tests.text_quotations_test.test_preprocess
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/shiningpanda/jobs/b20cb595/virtualenvs/d41d8cd9/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/var/lib/jenkins/workspace/lib-py-talon-pr/tests/text_quotations_test.py", line 693, in test_preprocess
    eq_(prepared_msg, quotations.preprocess(msg, '\n'))
AssertionError: 'Hello\nSee @@http://google.com\n@@ for more\ninformation\n On Nov 30, 2011, at 12:47 PM, Somebody <\n416ffd3258d4d2fa4c85cfa4c44e1721d66e3e8f4\[email protected]>wrote:\n\n> Hi' != u'Hello\nSee @@http://google.com\n@@ for more\ninformation On Nov 30, 2011, at 12:47 PM, Somebody <\n416ffd3258d4d2fa4c85cfa4c44e1721d66e3e8f4\[email protected]>wrote:\n\n> Hi'

Fix broken unit tests
f0791c9 
The 'wrote' token is not necessarily preceeded by a space, the email address enclosed
inside brackets can also be present: "<[email protected]>wrote:"
Fix the broken test by allowing either a space ('\s') or a closing bracket ('>')
@raphael0202
Copy link
Author

@obukhov-sergey I've sent a patch, the test should be fixed, even if I didn't manage to run the unit tests locally.

@obukhov-sergey
Copy link
Member

@mailgun-ci test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raphael0202 @mailgun-ci @obukhov-sergey