-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github action for automatically generating and tracking set implementation tracking issues #12941
base: master
Are you sure you want to change the base?
Conversation
From automation process:
Some notes:
|
To make sure I have it right, you'd want it to be split up into a few things?
Changes would be to remove the issue closing, make it ignore comments made by github bot, and move the javascript into its own file. Do I have that right? |
1 - yes
Yes. Except github bot comments ignore - what you mean by that? |
The GitHub bot comment thing was with the assumption of keeping the auto detect comments from people indicating in the comments that they're working on it. By having the bot make the first comment and making it ignore comments made by itself, you can include additional tasks mentioning the cards without triggering the check mark. But it seems that should also be a manual process, so disregard all of that. |
No needs in comments check at all. Main devs use a direct checkboxes to mark “in progress” status, comments for a new devs without edit access. |
Set tracking as far as I know is a manual process and doesn't extend to all of the sets. The wiki page for tracking set implementation progress is also outdated and rarely gets updated. This PR seeks to automate the process to reduce toil and reduce human error with the added benefit of tracking ALL sets.
See my fork for example of issues it generates.
Automatically closes tracking issues if all cards are implemented. Checks unimplemented cards when card name is mentioned in a comment. I could probably also require a specific format for this so the mere mention of the card doesn't check that card.
It will fail first few times it runs due to api rate limiting.
Also creates a Set-implementation-list.md which tracks the remaining cards per set in a single table. Utils/mtg-sets-data.txt would need to be updated to include more information for better formatting.
I noticed some split cards and double-faced cards are split up in Utils/mtg-cards-data.txt which get treated as individual cards.
Sets like Modern Horizons 3 Commander (M3C) has
Find // Finality
which it correctly parses, but sets like Commander Legends (CMR) splits the split cards into two likeResponse // Resurgence
gets split up intoResponse
andResurgence
.