Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Connection to Teams and the first Meeting Policies Tests #518

Merged
merged 10 commits into from
Dec 10, 2024

Conversation

weyCC81
Copy link
Contributor

@weyCC81 weyCC81 commented Nov 4, 2024

Add Connection
I have added the necessary test to connect to Teams without yet impacting the "All" scope.
In relation to -SkipGraphConnect I have adjusted some dependencies which need validation (see ToValidate and ToAdjust)

Teams Meeting Policies
I have implemented the first Test, which are also in the M365 Secure Score for the area Teams.

PS: As this is one of my first commits, I am really open to feedback

@weyCC81 weyCC81 requested review from a team as code owners November 4, 2024 23:07
@weyCC81 weyCC81 requested a review from a team as a code owner December 3, 2024 21:55
@merill
Copy link
Contributor

merill commented Dec 8, 2024

Thanks for this @weyCC81

One of the assumptions we make is that the user will not have the other modules like Teams and Exchange installed. So the part where Test-Cs... is called needs to be wrapped in a try..catch so it doesn't throw errors for users who don't have the module installed.

@weyCC81
Copy link
Contributor Author

weyCC81 commented Dec 8, 2024

Does the Build Error have to do something with me or?

@merill
Copy link
Contributor

merill commented Dec 10, 2024

No you can ignore that build error.

@merill
Copy link
Contributor

merill commented Dec 10, 2024

Thanks for the update @weyCC81

I've made some more updates after doing a few tests.

I think it's starting to get there. I'm going to go ahead and merge into main, but will open an issue to keep track of and address these to make it easier for users to follow the test and the recommendation.

  1. Move each test into Maester cmdlets
  2. Provider a reference number for each test e.g. MT1xxx (like we do with the other Maester tests)
  3. Include the reference number as a tag
  4. Improve the markdown to give guidance on the steps to get to the blade to make the change (including the descriptive label) and the Recommended Action step.

@merill merill merged commit 80a678a into maester365:main Dec 10, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants