fix(devnet): loosened devnet chain id restrictions #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trantorian1
added
bug
Trantorian1
requested review from
cchudant,
antiyro,
apoorvsadana and
jbcaron
apoorvsadana
approved these changes
Dec 30, 2024
| // to avoid accidental setups which would allow for replay attacks. This is | ||
| // possible if the devnet has the same chain id as another popular chain, | ||
| // allowing txs which occur on it to also be replayed on that other chain. | ||
| if run_cmd.devnet && (chain_config.chain_id == ChainId::Mainnet || chain_config.chain_id == ChainId::Sepolia) { |
There was a problem hiding this comment.
do we not want to give an option to force this? like if I really need to run a devnet with sepolia mode just so I can test some script or something else that I have?
There was a problem hiding this comment.
Idk, this seems liek something which would eventually make its way to prod 😅. Any situation in particular where you think this could be useful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
Current restrictions around devnet chain id to avoid replay attacks do not make entire sense and are a bit too strict.
Resolves: #302
What is the new behavior?
Devnet chain id restrictions have been loosed to only forbid devnets with
STARKNET_MAINNETorSTARKNET_SEPOLIAchain ids. An additinal warning has been added to theREADMEto warn agains such potential replay attacksDoes this introduce a breaking change?
No