Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1277 #1278

Merged
merged 2 commits into from
Nov 20, 2023
Merged

#1277 #1278

merged 2 commits into from
Nov 20, 2023

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Nov 20, 2023

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to help make sure it goes smoothly:

  • Raise a bug/feature request or start a discussion, ideally before writing your code! That way we can discuss the change and the approach.
  • Ensure the tests pass
  • Ensure code coverage does not decrease (if any source code was changed)
  • Appropriate docs and tests were updated (if necessary)

Fixes #<issue_number_goes_here>

@ghost
Copy link

ghost commented Nov 20, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
8.8% 8.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7553bc) 91.85% compared to head (635e862) 91.88%.

❗ Current head 635e862 differs from pull request most recent head 03650fb. Consider uploading reports for the commit 03650fb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1278      +/-   ##
==========================================
+ Coverage   91.85%   91.88%   +0.03%     
==========================================
  Files         189      190       +1     
  Lines        8385     8407      +22     
==========================================
+ Hits         7702     7725      +23     
+ Misses        683      682       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joocer joocer merged commit 1f16fb4 into main Nov 20, 2023
11 of 23 checks passed
@joocer joocer deleted the #1277-Order branch November 20, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant