Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1267 #1272

Merged
merged 1 commit into from
Nov 19, 2023
Merged

#1267 #1272

merged 1 commit into from
Nov 19, 2023

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Nov 19, 2023

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to help make sure it goes smoothly:

  • Raise a bug/feature request or start a discussion, ideally before writing your code! That way we can discuss the change and the approach.
  • Ensure the tests pass
  • Ensure code coverage does not decrease (if any source code was changed)
  • Appropriate docs and tests were updated (if necessary)

Fixes #1267

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ghost
Copy link

ghost commented Nov 19, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (80a94f7) 91.59% compared to head (3f401b7) 91.79%.
Report is 20 commits behind head on main.

Files Patch % Lines
opteryx/utils/file_decoders.py 75.86% 7 Missing ⚠️
opteryx/operators/join_node.py 33.33% 2 Missing ⚠️
opteryx/components/binder/binder_visitor.py 96.87% 1 Missing ⚠️
opteryx/components/heuristic_optimizer.py 97.72% 1 Missing ⚠️
opteryx/connectors/sql_connector.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1272      +/-   ##
==========================================
+ Coverage   91.59%   91.79%   +0.20%     
==========================================
  Files         184      187       +3     
  Lines        8158     8347     +189     
==========================================
+ Hits         7472     7662     +190     
+ Misses        686      685       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joocer joocer merged commit ccc2738 into main Nov 19, 2023
15 of 24 checks passed
@joocer joocer deleted the #1267 branch November 19, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 MySQL server used in test suite keeps failing
1 participant