Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sample app to React Native 0.72 #173

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dylmye
Copy link

@dylmye dylmye commented Nov 7, 2023

Summary

I created this PR as a part of an effort to set up auto-linking. Creating a modern test app is beneficial to ensuring everything works as expected in real-world use.

  • Replace old sample app with the template from npx react-native@latest init, set up mParticle and the same tests + outputs as the old sample app
  • Updated dead links in README
  • Removed unused generic render tests in sample app directory

Note: typescript declarations for react-native-mparticle not included as it's not my property

Testing Plan

  • Set workplace api key and secret in android/iOS files where necessary

Master Issue

n/a

@dylmye dylmye marked this pull request as ready for review November 8, 2023 16:04
@dylmye
Copy link
Author

dylmye commented Dec 14, 2023

Would appreciate mParticle eyes/thoughts on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant