Cleanups and moving old code out #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to polygon extensions much faster and less of a hog on memory
…ons used in improve_invalid_cs(), should improve speed, memory usage on larger networks, cs points, and transects
…oving and speeding up cross section improvment functions, WIP
… all hydrofabric3D function to use user defined ids / crosswalk_ids
…ss section improvement functions
…unctions, almost complete with transect
…ng prescribed IDs, continued working on tests for cross section point extraction code
…ctions used for testing scripts
…k_attributes() to handle missing point_types better and exported the function, working on valid_banks tests with new version of get_bank_attributes()
…nd if they don't they are given default NA / valid_banks = FALSE values, adding more get_bank_attributes() tests
…t assigned bank attributes / validity checking
…es for get_bank_attributes
… left or right bank point_types, added tests for get_relief(), added data and starting testing for cross section pts with NA Z values from DEM
… cs_pts if they have any missing Z values (drop_incomplete_cs_pts()) and added this function to get_improved_cs_pts() to deal with errors caused by NA values in DEM
…ves of Z depth for cs point classification
…tarted tests for point classificaitons
…ting data generation for cross section point classification
…lect in renumber_cs_ids(), work on classificaiton algo, bumped version
…functionality to ahg_estimates and ML code, added crosswalk_id to extend_by_percent(), bumped version
…rted function, bumped version
…_extensions_by_id to always return all input crosswalk_id/cs_id with distances values of 0 if they dont have any extension distances
… and bumped version, added tests for get_extensions_by_id function thats used for determing transect extension distances to polygons
…ints, bumped version
…n functions name, added more tests for extend_transect_side functions and fixed a bug in the extension that was incorrectly dropping some transect extensions
…ts all at the true bottom of a cs
…sts to fit this change, bumped version, a breaking change for any code that uses old 'id' parameter
…to a set of XY columns
… conveniance function for converting points to XY ocolumns, bumped version
…code to a bottom_finder.R script, bumped version
…ance function for taking the updated cross section length information from get_improved_cs_pts and applying those changes to the original transect lines
… when generating new IDs, added a internal validation fgunction, has_all_unique_tmp_ids(), bumped version
…good to go, still need to add manuals and roxygen comments to these
…n rules for extensions
…engths(), finishing up cs based trtansect extensions and validation revision
…, the same logic used in cs point based extensions, added a single test for this, updated roxygen comments, added a junction_flowlines.gpkg for further testing
… only, added tests for classify_derivatives, renamed transect shortening functions, added validator functions to package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend_transects_to_polygonswith new version of the functionextend_transects_to_polygonsvalidators.R) which validate transects/cross section points data is as anticipated and aligns with a given set of flowlines and/or transects in the case of cross section points