Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed eslint issues and one comparison/assignment mistake #224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed eslint issues and one comparison/assignment mistake #224

wants to merge 2 commits into from

Conversation

mdx0111
Copy link

@mdx0111 mdx0111 commented Jan 29, 2020

Fixed eslint issues.
Also fixed an comparison/assignment issue on line 44 inside "Node.prototype.ancestors" function.

ludo
ludo requested changes Jan 29, 2020
View reviewed changes
Copy link
Owner

@ludo ludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution! Have a look at my comment about the assignment/comparison.

Could you run eslint with an indent size of 2 spaces? It's difficult to see what else has changed :)

jquery.treetable.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludo ludo ludo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdx0111 @ludo @ntxmasoudd