Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow treetable for unsorted html #202

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

rulrok
Copy link

@rulrok rulrok commented Jul 7, 2017

This PR changes the plugin to allow treetable to correctly initialize a table if the HTML is not sorted properly.

@ludo
Copy link
Owner

ludo commented Jul 7, 2017

Nice 👍 Do you think you could make this behavior optional? If the nodes are already ordered it would be an unnecessary performance hit to do this, right?

@rulrok
Copy link
Author

rulrok commented Jul 8, 2017

Oh sure, I will update that and report back here.

@rulrok
Copy link
Author

rulrok commented Jul 10, 2017

@ludo I had to autoindent the file first. My editor just refused to save the file without doing it. I made it on a separate commit to avoid confusion.
I've added one setting which defaults to false. See if it is enough. Don't forget to update the documentation on the website if everything if alright :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants