Restructure application routing #1141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
commented
Dec 20, 2024
| from OpenOversight.app.utils.forms import set_dynamic_default | ||
| from OpenOversight.app.utils.general import validate_redirect_url | ||
|
|
||
|
|
||
| auth = Blueprint("auth", __name__, url_prefix="/auth") |
There was a problem hiding this comment.
I feel like the url_prefix belongs with the creation of the Blueprint, but I'd be happy to shift it back to the application's __init__.py file if everyone else would prefer that.
michplunkett
commented
Dec 20, 2024
Comment on lines
-127
to
-128
| # Ensure the file is read/write by the creator only | ||
| SAVED_UMASK = os.umask(0o077) |
There was a problem hiding this comment.
This isn't used anywhere in views.py.
michplunkett
requested review from
abandoned-prototype,
sea-kelp,
b-meson and
AetherUnbound
and removed request for
abandoned-prototype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Sets the groundwork for this issue: #385
Description of Changes
Simplifying the import logic for the
authandmainroutes of the application. This also sets up the work for this PR: #1138Tests and Linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.