Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the /find department sort #1133

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Fix the /find department sort #1133

merged 4 commits into from
Nov 8, 2024

Conversation

michplunkett
Copy link
Collaborator

@michplunkett michplunkett commented Nov 7, 2024 •
edited
Loading

Fixes issue

Addresses TO-DO in code.

Description of Changes

The /find route was using an unsorted list of departments unlike the rest of the application.

Before:
Screenshot 2024-11-06 at 10 13 13 PM

After:
Screenshot 2024-11-06 at 10 13 36 PM

Tests and Linting

  • This branch is up-to-date with the develop branch.
  • pytest passes on my local development environment.
  • pre-commit passes on my local development environment.

@michplunkett michplunkett marked this pull request as draft November 7, 2024 04:07
@michplunkett michplunkett self-assigned this Nov 7, 2024
@michplunkett michplunkett marked this pull request as ready for review November 7, 2024 04:14
AetherUnbound
AetherUnbound approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, LGTM!

@michplunkett michplunkett merged commit 2ac2240 into develop Nov 8, 2024
3 checks passed
@michplunkett michplunkett deleted the fix-dept-sort branch November 8, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AetherUnbound AetherUnbound AetherUnbound approved these changes

@b-meson b-meson Awaiting requested review from b-meson

@abandoned-prototype abandoned-prototype Awaiting requested review from abandoned-prototype

@sea-kelp sea-kelp Awaiting requested review from sea-kelp

@null-space-0 null-space-0 Awaiting requested review from null-space-0

Assignees

@michplunkett michplunkett

Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michplunkett @AetherUnbound