Fix production deployments #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushing into the main branch is now longer required for production deployments, but the task.py script was hard-coded to fetch the main branch. The script will now fetch the given git ref, in the prod deploy case this is the tag used in the release.
abandoned-prototype
requested review from
b-meson,
michplunkett and
sea-kelp
abandoned-prototype
changed the title
b-meson
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Prod deploy failed.
Description of Changes
Pushing into the main branch is now longer required for production deployments, but the task.py script was hard-coded to fetch the (out of date) main branch.
After this change, the script will now fetch the given git ref, in the prod deploy case this is the tag used in the release.
Notes for Deployment
Tested task.py script locally
Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.