Deploy to prod on tag creation #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the previous workflow, where a push to the main branch was needed.
abandoned-prototype
requested review from
b-meson,
michplunkett and
sea-kelp
| push: | ||
| branches: | ||
| - develop | ||
| - main |
There was a problem hiding this comment.
I think it may be worth taking off main if we are going to scrap it at some point.
michplunkett
changed the title
michplunkett
approved these changes
Sep 22, 2023
|
Leaving both main and develop for now allows us to remove the main branch and rename develop to main if we want at a later point. (And then clean up this workflow) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
#1030
Description of Changes
Previously a push on the main branch triggered a deploy to prod. In the future, creating a release will trigger that push.
The change is already built in a way that we can delete the main branch and rename the develop branch to main as a next step (once we confirmed everything works).
Notes for Deployment
I was only able to partially test this, so we will see how it goes.
Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.