DM-44230: Add Slack error reporting #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
May 6, 2024
jonathansick
force-pushed
the
tickets/DM-44230
branch
2 times, most recently
from
25f29ae to
ee2204e
Compare
rra
approved these changes
May 6, 2024
The `POST /fastapi-bootcamp/error-demo` endpoint specifically raises these errors for demonstration.
It's not really needed here.
jonathansick
force-pushed
the
tickets/DM-44230
branch
3 times, most recently
from
48f71ca to
8bcee83
Compare
|
@rra Thanks for all the suggestions. I also ended up using that pagination dependency on the endpoint for getting a collection of observers, |
rra
approved these changes
May 7, 2024
Comment on lines
69
to
73
| page : int, optional | ||
| The page number, by default 1. | ||
| limit : int, optional | ||
| The number of items to return per page, by default 10. | ||
| order : SortOrder, optional |
There was a problem hiding this comment.
Minor nit: I think the type information in the docstring can be dropped.
There was a problem hiding this comment.
Oops, I was going fast and Copilot auto-filled this 😓
src/fastapibootcamp/domain/models.py
Outdated
| @@ -10,7 +10,9 @@ | |||
| from astropy.coordinates import AltAz, Angle, SkyCoord | |||
| from astropy.time import Time | |||
|
|
|||
| __all__ = ["Observer", "TargetObservability"] | |||
| from fastapibootcamp.dependencies.pagination import Pagination | |||
There was a problem hiding this comment.
Minor nit: Do you want to use a relative import here? I usually do and it looked like you were elsewhere, although I didn't know if there was a reason to avoid it here.
This lesson explores custom FastAPI dependencies. We cover the two styles. For a functional dependency, we're adding a pagination dependency that adds query strings parameters for a user to control pagination. For a class-based singleton dependency, we have a simple example that initializes a semi-random string to show how that value is persistent across requests.
This doesn't actually compatible with mypy/FastAPI yet.
This uses the same Pagination dependency we developed for the initial lessons.
Rather than breaking out the Pagination in the service and storage layer requests, we'll continue to pass it through. This slightly breaks the rules because now the same model is used both internally and for the API, but it is a pragmatic judgment call.
jonathansick
force-pushed
the
tickets/DM-44230
branch
from
8bcee83 to
b638abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
POST /fastapi-bootcamp/error-demoendpoint specifically raises these errors for demonstration.I also added a
GET /fastapi-bootcamp/dependency-demoendpoint that explores writing custom dependencies. I'm not sure of the terminology, but I'm calling one type "functional dependencies" and the other "class-based" dependencies / "stateful" dependencies. Suggestions are welcome on this terminology!