Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fleet/kyverno) add alerts #343

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

(fleet/kyverno) add alerts #343

wants to merge 2 commits into from

Conversation

jhoblitt
Copy link
Member

No description provided.

@jhoblitt jhoblitt added the enhancement New feature or request label Apr 25, 2024
Copy link
Contributor

@cbarria cbarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great 👍🏻

Copy link
Contributor

@fbegyn fbegyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we might wanna allign all the labels before merging these requests. Alertwise and query wise these seem alright.

Generally we use summary annotations to create a description that is global without any template variables in it, while description annotations will contain specific information about the alert with template variables in it. This allows for a large group of alerts to be grouped together an announced by the summary annotation.

@jhoblitt jhoblitt force-pushed the IT-5176/kyverno-alerts branch from 343ac06 to 5df269b Compare May 13, 2024 23:31
Copy link
Contributor

@fbegyn fbegyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing labels for alert delivery. If that's not the goal here, it can be merged as is.

expr: sum(kyverno_policy_execution_duration_seconds_sum{cluster=~".*"}) / sum(kyverno_policy_execution_duration_seconds_count{cluster=~".*"}) > 0.1
for: 15s
labels:
severity: warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these alerts to end up somewhere, a label receivers: ",slack," needs to be configured.

@fbegyn fbegyn force-pushed the IT-5176/kyverno-alerts branch from 5df269b to 332c7bb Compare June 13, 2024 15:44
@jhoblitt jhoblitt force-pushed the IT-5176/kyverno-alerts branch from 332c7bb to eb1eb0c Compare June 20, 2024 16:00
@jhoblitt jhoblitt force-pushed the IT-5176/kyverno-alerts branch from eb1eb0c to 5bb52ac Compare June 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants