-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fleet/kyverno) add alerts #343
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we might wanna allign all the labels before merging these requests. Alertwise and query wise these seem alright.
Generally we use summary
annotations to create a description that is global without any template variables in it, while description
annotations will contain specific information about the alert with template variables in it. This allows for a large group of alerts to be grouped together an announced by the summary annotation.
343ac06
to
5df269b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing labels for alert delivery. If that's not the goal here, it can be merged as is.
expr: sum(kyverno_policy_execution_duration_seconds_sum{cluster=~".*"}) / sum(kyverno_policy_execution_duration_seconds_count{cluster=~".*"}) > 0.1 | ||
for: 15s | ||
labels: | ||
severity: warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these alerts to end up somewhere, a label receivers: ",slack,"
needs to be configured.
5df269b
to
332c7bb
Compare
332c7bb
to
eb1eb0c
Compare
eb1eb0c
to
5bb52ac
Compare
No description provided.