Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Make compose for playwright tests more reliable #10065

Merged
merged 12 commits into from
Dec 25, 2024

Conversation

muradium
Copy link
Contributor

@muradium muradium commented Dec 22, 2024

Checklist

General

Client

Motivation and Context

Currently, the build plans for Playwright tests have inconsistent behavior and compose command sometimes fails due to having networks and network_mode both specified at the same time for artemis-playwright service. This happens because we override the networks using !reset [] action, but it is not an official compose syntax and sometimes the networks are not reset before the network_mode is used, which causes an error.

Description

This PR removes the networks section from playwright.yml compose file and leaves the networking to its extension. This change avoids the inconsistency caused by networks: !reset [] trick used on playwright-E2E-tests-mysql-localci.yml. Instead we specify only network-mode on it and we don't have to reset the networks as it's not specified on the parent compose file anymore.

Steps for Testing

  • Code Review: Ensure that tests pass for valid reasons and improvements make sense.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@muradium muradium changed the title Chore/playwright/make compose more reliable Development: Make compose for playwright tests more reliable Dec 23, 2024
@muradium muradium changed the title Development: Make compose for playwright tests more reliable Development: Make compose for Playwright tests more reliable Dec 23, 2024
@muradium muradium marked this pull request as ready for review December 23, 2024 14:51
@muradium muradium requested a review from a team as a code owner December 23, 2024 14:51
Copy link
Member

@BBesrour BBesrour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm. However, there are many failing tests in the playwright jobs, is that normal?

@muradium
Copy link
Contributor Author

@BBesrour I think that one failure happened due to another reason - probably because I started the tests too early while the push was still ongoing 😄 I'll run the build a few more times to make sure it's consistently succeeding

Copy link
Contributor

@SimonEntholzer SimonEntholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krusche krusche changed the title Development: Make compose for Playwright tests more reliable Development: Make compose for playwright tests more reliable Dec 25, 2024
@krusche krusche merged commit 9754288 into develop Dec 25, 2024
50 of 52 checks passed
@krusche krusche deleted the chore/playwright/make-compose-more-reliable branch December 25, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants