-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Make compose for playwright tests more reliable
#10065
Development
: Make compose for playwright tests more reliable
#10065
Conversation
Development
: Make compose for playwright tests more reliable
Development
: Make compose for playwright tests more reliableDevelopment
: Make compose for Playwright tests more reliable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm. However, there are many failing tests in the playwright jobs, is that normal?
@BBesrour I think that one failure happened due to another reason - probably because I started the tests too early while the push was still ongoing 😄 I'll run the build a few more times to make sure it's consistently succeeding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code, and all recent runs work reliably
https://bamboo.ase.in.tum.de/build/result/viewBuildResults.action?buildKey=ARTEMIS-AEPTMA1345-DA&buildNumber=21
Development
: Make compose for Playwright tests more reliableDevelopment
: Make compose for playwright tests more reliable
Checklist
General
Client
Motivation and Context
Currently, the build plans for Playwright tests have inconsistent behavior and compose command sometimes fails due to having
networks
andnetwork_mode
both specified at the same time for artemis-playwright service. This happens because we override thenetworks
using!reset []
action, but it is not an official compose syntax and sometimes the networks are not reset before the network_mode is used, which causes an error.Description
This PR removes the
networks
section fromplaywright.yml
compose file and leaves the networking to its extension. This change avoids the inconsistency caused bynetworks: !reset []
trick used onplaywright-E2E-tests-mysql-localci.yml
. Instead we specify onlynetwork-mode
on it and we don't have to reset the networks as it's not specified on the parent compose file anymore.Steps for Testing
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review