Remove scale property from Apollon #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…ollon into feature/remove-scale
# Conflicts: # public/styles.css # src/main/components/canvas/editor.tsx # src/main/components/canvas/zoom-pane.tsx # src/main/components/connectable/connection-preview.tsx # src/main/components/uml-element/movable/movable.tsx # src/main/services/editor/editor-reducer.ts # src/main/services/editor/editor-repository.ts # src/main/services/editor/editor-types.ts # src/main/utils/clamp.ts # src/tests/unit/components/update-pane/__snapshots__/update-pane-test.tsx.snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer:
This PR is based off of and includes changes from #302. Reviewing this changes should become drastically easier once the base PR is merged.
Checklist
Motivation and Context
Description
This PR removes the existing scale factor implementation entirely as it is no longer needed with the new canvas zooming approach.
Steps for Testing
As this change does not change existing functionality nor add new functionality but rather only removes no longer used code, the most sensible way to test this change is by making sure the editor still behaves as expected.
Test Coverage
Screenshots