Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with end and start node alignment #304

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Fix issues with end and start node alignment #304

merged 2 commits into from
Sep 26, 2023

Conversation

matthiaslehnertum
Copy link
Collaborator

@matthiaslehnertum matthiaslehnertum commented Sep 26, 2023 •
edited
Loading

This PR fixes issues with the alignment of start and end node on the activity diagram.

Screenshot 2023-09-26 at 09 38 48

Checklist

  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes
  • I translated all the newly inserted strings into German and English

Motivation and Context

Description

Steps for Testing

  1. ...

Test Coverage

File Branch Line

Screenshots

AlexanderG2207
AlexanderG2207 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@AlexanderG2207 AlexanderG2207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and works well. After updating the snapshots, all tests pass locally as well.

@krusche krusche merged commit a476eca into develop Sep 26, 2023
3 checks passed
@krusche krusche deleted the feature/activity-alignment-improvements branch September 26, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderG2207 AlexanderG2207 AlexanderG2207 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthiaslehnertum @AlexanderG2207 @krusche