Fix too much unused space on mobile, landscape view #640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
lightbox2 is great, I only have a single issue with it, namely too much unused space on mobile, landscape view:
In lightbox.js I find the magic number "120"
! maxImageHeight = windowHeight - self.containerPadding.top - self.containerPadding.bottom - self.imageBorderWidth.top - self.imageBorderWidth.bottom - 120;
I'm not sure what this is about. I may be wrong, but it seems the only height that needs to be subtracted is the top offset and the "lb-dataContainer" height below the image (45px in my case), thous:
maxImageHeight = windowHeight - self.containerPadding.top - self.containerPadding.bottom - self.imageBorderWidth.top - self.imageBorderWidth.bottom - 45 - self.$lightbox[0].offsetTop;
Now, when my site is in mobile mode, I can set #lightbox "top" to 0:
@media screen and (max-width: 1050px) { #lightbox { top: 0 !important; } }
And everything looks great, with no space wasted: