Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .travis.yml customization #226

Merged
merged 3 commits into from
Dec 4, 2024
Merged

remove .travis.yml customization #226

merged 3 commits into from
Dec 4, 2024

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Nov 14, 2024

No description provided.

@jsvd jsvd marked this pull request as ready for review November 18, 2024 09:57
@donoghuc
Copy link
Contributor

donoghuc commented Nov 20, 2024

CI summary:

logstash-1  |   1) LogStash::Inputs::Tcp `ecs_compatibility => v8` should read plain with unicode
logstash-1  |      Failure/Error: expect(event.get(ecs_select[disabled: "[@metadata][ip_address]", v1: "[@metadata][input][tcp][source][ip]"])).to eq('127.0.0.1')
logstash-1  |      
logstash-1  |        expected: "127.0.0.1"
logstash-1  |             got: "0:0:0:0:0:0:0:1"
logstash-1  |      
logstash-1  |        (compared using ==)
logstash-1  |      # ./spec/inputs/tcp_spec.rb:93:in `block in <main>'
logstash-1  |      # ./spec/inputs/tcp_spec.rb:90:in `block in <main>'
logstash-1  |      # ./spec/inputs/tcp_spec.rb:87:in `block in times'
logstash-1  |      # ./spec/inputs/tcp_spec.rb:87:in `block in <main>'
logstash-1  |      # ./Rakefile:14:in `block in <main>'

Updates

  • Pushed 3d73567 to address ipv6 representation of loopback addr.

This commit updates the test expectation to handle both ipv4 and ipv6 loopback
addresses. Both forms appear to be present across the test matrix. This should
allow us to maintain the compatability regarless of the representation of the
loopback address.
@donoghuc
Copy link
Contributor

Well, i went to reproduce the ipv4 vs ipv6 issue and I could not. The only failures left are the same encoding ones as are in flight. I will keep an eye on this to see if the issues come back. I see a couple places where there may be non deterministic behavior when resolving between v4 and v6 but I cant prove it. 👻

@jsvd
Copy link
Member Author

jsvd commented Nov 27, 2024

It did happen again 2 hours ago: https://app.travis-ci.com/github/logstash-plugins/logstash-input-tcp/jobs/628356013#L1116, so it's probably best to keep the validation for both ipv6 and ipv4

@donoghuc
Copy link
Contributor

Ok. Just deleted the revert commit for the work around in the test. I went on a goose chase last week trying to nail down where exactly that behavior was showing up but I was never able to actually put my finger on it. Unfortunately I didnt really take good notes on where all I went with it 🙃

@jsvd
Copy link
Member Author

jsvd commented Nov 28, 2024

The build is now failing only due to main and 8.x snapshots not having been built yet across the stack, so we can merge this.

@jsvd jsvd requested a review from donoghuc November 28, 2024 12:10
@donoghuc donoghuc merged commit 3c0c18a into main Dec 4, 2024
1 of 3 checks passed
@jsvd jsvd deleted the jsvd-patch-1 branch December 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants