-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove .travis.yml customization #226
Conversation
CI summary:
Updates
|
This commit updates the test expectation to handle both ipv4 and ipv6 loopback addresses. Both forms appear to be present across the test matrix. This should allow us to maintain the compatability regarless of the representation of the loopback address.
Well, i went to reproduce the ipv4 vs ipv6 issue and I could not. The only failures left are the same encoding ones as are in flight. I will keep an eye on this to see if the issues come back. I see a couple places where there may be non deterministic behavior when resolving between v4 and v6 but I cant prove it. 👻 |
It did happen again 2 hours ago: https://app.travis-ci.com/github/logstash-plugins/logstash-input-tcp/jobs/628356013#L1116, so it's probably best to keep the validation for both ipv6 and ipv4 |
c54baeb
to
3d73567
Compare
Ok. Just deleted the revert commit for the work around in the test. I went on a goose chase last week trying to nail down where exactly that behavior was showing up but I was never able to actually put my finger on it. Unfortunately I didnt really take good notes on where all I went with it 🙃 |
The build is now failing only due to main and 8.x snapshots not having been built yet across the stack, so we can merge this. |
No description provided.