Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to clean up the logging setup interface. Previously,
logix.setup
used to have three keys oflog
,save
, andstatistic
, and withinstatistic
we additionallyforward
,backward
, andgrad
. In fact, we only need three keys offorward
,backward
, andgrad
as we show below:An additional change we introduce is separating
save
from the logging setup. Instead users can enable saving both globally (dataset-level) or locally (batch-level) as below:I believe this interface would ease users to more easily define and plug-in their own statistics computation primitives.